feat(react): upgrade Downshift dependency to v5 #5357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-components-react ready! Built with commit ae94219 https://deploy-preview-5357--carbon-components-react.netlify.com |
|
Are we not going to man-in-the-middle the |
|
Deploy preview for carbon-elements ready! Built with commit 7d09374 |
vpicone
suggested changes
Feb 14, 2020
|
Do we have a list of follow up issues to look into after this? It unlocks some really nice things: #4950 |
dakahn
changed the title
|
@vpicone not that i'm aware of 🤔 |
|
closing and reopening as #5373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were on v1 Downshift and there are quite very meaningful accessibility fixes/improvements made. This PR upgrades downshift and updates tests/code for any breaking changes.
included changes
to test
Open Multiselect, Dropdown, and Combobox and makes sure all functionality is working as expected 🏄
@aledavila @abbeyhrt and anyone on core working on our listy-dropdowny components. We should do a quick check on any bugs in our backlog and see if we don't get free fixes via this update 👍