Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled dropdown item #4950

Closed

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Jan 3, 2020

Closes #4949

TODO: fix broken tests

Changelog

New

  • Update Downshift to v4. This makes it so the disabled items are skipped when navigating via keyboard
  • Styles for individual disabled options

Changed

  • Update internal Downshift props to accomodate breaking changes

Testing / Reviewing

  • We jumped 3 versions in Downshift. I got all the breaking changes but we should probably manually test the Downshift components: (ComboBox, Dropdown, FilterableMultiSelect, Multiselect)

@netlify
Copy link

netlify bot commented Jan 3, 2020

Deploy preview for the-carbon-components ready!

Built with commit 9f1490b

https://deploy-preview-4950--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 3, 2020

Deploy preview for carbon-components-react failed.

Built with commit 9f1490b

https://app.netlify.com/sites/carbon-components-react/deploys/5e0faf1c4283bd00087c4661

@netlify
Copy link

netlify bot commented Jan 3, 2020

Deploy preview for carbon-elements failed.

Built with commit 9f1490b

https://app.netlify.com/sites/carbon-elements/deploys/5e0faf1c61e1a4000af01a2a

@netlify
Copy link

netlify bot commented Jan 3, 2020

Deploy preview for the-carbon-components ready!

Built with commit 05997d0

https://deploy-preview-4950--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 3, 2020

Deploy preview for carbon-components-react ready!

Built with commit 05997d0

https://deploy-preview-4950--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 3, 2020

Deploy preview for carbon-elements failed.

Built with commit 05997d0

https://app.netlify.com/sites/carbon-elements/deploys/5e0fb022dcfeb700088c61e7

@ghost ghost requested review from asudoh and dakahn January 4, 2020 05:05
@joshblack
Copy link
Contributor

Can we do the jump to v4 in a minor? Had assumed we couldn't since we forward props to downshift with the downshiftProps option 😞

@github-actions github-actions bot added squad: system package: react carbon-components-react labels Jan 6, 2020
@vpicone
Copy link
Contributor Author

vpicone commented Jan 17, 2020

@joshblack gonna close this for now, maybe keep track of it if you wanna update Downshift in the future (it should prob be it's own PR that would be a blocker for this otherwise simple implementation. Could do a little man in the middle to guard folks passing in custom props that have been deprecated. They only deprecated the name, not any functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: Provide support to disable specific values in the dropdown
4 participants