-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled dropdown item #4950
Disabled dropdown item #4950
Conversation
Deploy preview for the-carbon-components ready! Built with commit 9f1490b https://deploy-preview-4950--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react failed. Built with commit 9f1490b https://app.netlify.com/sites/carbon-components-react/deploys/5e0faf1c4283bd00087c4661 |
Deploy preview for carbon-elements failed. Built with commit 9f1490b https://app.netlify.com/sites/carbon-elements/deploys/5e0faf1c61e1a4000af01a2a |
Deploy preview for the-carbon-components ready! Built with commit 05997d0 https://deploy-preview-4950--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 05997d0 https://deploy-preview-4950--carbon-components-react.netlify.com |
Deploy preview for carbon-elements failed. Built with commit 05997d0 https://app.netlify.com/sites/carbon-elements/deploys/5e0fb022dcfeb700088c61e7 |
Can we do the jump to v4 in a minor? Had assumed we couldn't since we forward props to downshift with the |
@joshblack gonna close this for now, maybe keep track of it if you wanna update Downshift in the future (it should prob be it's own PR that would be a blocker for this otherwise simple implementation. Could do a little man in the middle to guard folks passing in custom props that have been deprecated. They only deprecated the name, not any functionality. |
Closes #4949
TODO: fix broken tests
Changelog
New
Changed
Testing / Reviewing
ComboBox
,Dropdown
,FilterableMultiSelect
,Multiselect
)