fix(combobox/text-input): add svg top positioning for IE11 #5362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakahn
requested review from
asudoh and
joshblack
and removed request for
a team
|
Deploy preview for carbon-elements ready! Built with commit 4d68562 |
|
Deploy preview for carbon-components-react ready! Built with commit 4d68562 https://deploy-preview-5362--carbon-components-react.netlify.com |
asudoh
requested review from
a team and
laurenmrice
and removed request for
a team
|
I checked all the other browsers just in case and they look good. Will see if I can check ie11 with josh today (since I can't view on my comp) |
joshblack
reviewed
Feb 17, 2020
| @@ -343,6 +343,7 @@ $list-box-menu-width: rem(300px); | |||
| .#{$prefix}--list-box__selection { | |||
| position: absolute; | |||
| right: rem(33px); // to preserve .5rem space between icons according to spec | |||
| top: 0.35rem; | |||
There was a problem hiding this comment.
Do we need to use bespoke positioning or could we do top: 0; bottom: 0; to center?
There was a problem hiding this comment.
Seems like we settled on top: 50%; bottom: translateY(-50%); 👍
laurenmrice
approved these changes
Feb 17, 2020
joshblack
approved these changes
Feb 17, 2020
asudoh
approved these changes
Feb 17, 2020
|
this causes a regression for multiselects
|
|
Oh looks a good catch - Have you reported it @emyarod? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #5335
Adds
topattribute to SVG positioning in text-input and combobox getting that SVG sitting properly in the form element. Also adds the css-reset to combobox so that when #5357 lands the text-input willdisplay: nonefor::-ms-cleargetting rid of that big funky browser default X 👍Testing / Reviewing
check the clear button positioning in IE11 for both text-input and combobox. Then check the clear button positioning in modern browsers just to be safe 🦅
Note
I didn't stick the top attribute into a query for IE11 specifically because adding the
topattribute had no negative effect on Firefox and Chrome. If that wont fly let me know 💟