Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): update button colors, focus states #3598

Merged
merged 5 commits into from
Aug 1, 2019
Merged

fix(button): update button colors, focus states #3598

merged 5 commits into from
Aug 1, 2019

Conversation

tw15egan
Copy link
Collaborator

Closes #3594
Closes #3592

Changelog

New

  • Correct focus states for Tertiary Button
  • Correct focus states for Icon only button

Testing / Reviewing

  • Test the icon-only button and tertiary button focus styles

@tw15egan tw15egan requested a review from a team July 30, 2019 23:26
@ghost ghost requested review from asudoh and jnm2377 and removed request for a team July 30, 2019 23:26
@asudoh asudoh requested a review from a team July 30, 2019 23:29
@ghost ghost requested review from shixiedesign and removed request for a team July 30, 2019 23:29
@netlify
Copy link

netlify bot commented Jul 30, 2019

Deploy preview for the-carbon-components ready!

Built with commit 2d1e62a

https://deploy-preview-3598--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jul 30, 2019

Deploy preview for carbon-elements ready!

Built with commit 2d1e62a

https://deploy-preview-3598--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jul 30, 2019

Deploy preview for carbon-components-react ready!

Built with commit 2d1e62a

https://deploy-preview-3598--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jul 30, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit d0ab6fa

https://deploy-preview-3598--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jul 30, 2019 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit d0ab6fa

https://deploy-preview-3598--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jul 30, 2019 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit d0ab6fa

https://deploy-preview-3598--carbon-elements.netlify.com

jnm2377
jnm2377 approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

shixiedesign
shixiedesign approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@shixiedesign shixiedesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focus states all looks good! Can we keep #3594 open? Just wanna keep an eye on the icon issue so it doesn't get lost.

image

@asudoh asudoh merged commit 5f10330 into carbon-design-system:master Aug 1, 2019
This was referenced Aug 1, 2019
Closed
Closed
@tw15egan tw15egan mentioned this pull request Aug 6, 2019
Closed
2 tasks
@hixio-mh hixio-mh mentioned this pull request Jan 22, 2021
Merged
@tw15egan tw15egan deleted the tertiary-button-update branch March 3, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod left review comments

@jnm2377 jnm2377 jnm2377 approved these changes

@shixiedesign shixiedesign shixiedesign approved these changes

@asudoh asudoh Awaiting requested review from asudoh

Assignees
No one assigned
Labels
status: ready for review 👀 status: visual review 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Button] 2 bugs, icons in button & icon button focus state Tertiary button is missing focus styles
5 participants
@tw15egan @emyarod @shixiedesign @jnm2377 @asudoh