Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tertiary button is missing focus styles #3592

Closed
tw15egan opened this issue Jul 30, 2019 · 2 comments · Fixed by #3598
Closed

Tertiary button is missing focus styles #3592

tw15egan opened this issue Jul 30, 2019 · 2 comments · Fixed by #3598
Assignees
@tw15egan
Labels
type: a11y ♿ type: bug 🐛

Comments

@tw15egan
Copy link
Collaborator

Focus styles are added but blend in with the border and white background
@tw15egan
Copy link
Collaborator Author

Tagging @carbon-design-system/design to see what focus styles should be

@aagonzales
Copy link
Member

This is the spec for tertiary buttons:

image
image

Focus style:

Background color: $interactive-03
Text size: $body-short-01 
Text color: $text-04
Border: 2px inner stroke ($focus)

@tw15egan tw15egan self-assigned this Jul 30, 2019
@tw15egan tw15egan mentioned this issue Jul 30, 2019
Merged
@hixio-mh hixio-mh mentioned this issue Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
type: a11y ♿ type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(button): update button colors, focus states tw15egan/carbon
2 participants
@aagonzales @tw15egan