Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Add' Primary Button lacks focus indicator #3623

Closed
mbgower opened this issue Aug 1, 2019 · 1 comment
Closed

'Add' Primary Button lacks focus indicator #3623

mbgower opened this issue Aug 1, 2019 · 1 comment

Comments

@mbgower
Copy link

mbgower commented Aug 1, 2019

'Add' Primary Button lacks focus indicator

Environment

Themes

Operating system
Windows 7

Browser
Chrome and Firefox

Detailed description

The + button has no focus indictor, instead displaying "Add" on focus as a tooltip
it's an extremely unusual way of indicating focus. As well, it is the same indicator as the hover.
Note that when the item is selected, there is a (faint) inner focus rectangle around the + symbol on hover. Unclear why it is not visible when not hovered. Note also that Secondary buttons have a (poor) focus rectangle on the + button.

What did you expect to happen?
I expected it to receive a standard dotted rectangle focus indicator.

What happened instead?
There is no focus indicator. For a user who is in a magnified view, they may not even see the "Add" pop up content, so it is a very poor indicator that the button has focus.

What WCAG 2.1 checkpoint does the issue violate?
Focus Visible

Steps to reproduce the issue

  1. Open up the themes page and select Button from the left nav
  2. Click or otherwise put focus on the first button, then tab to the "+" button
  3. To see the faint focus indicator that exists, select the Add button, then hover over it.

Additional information

@tw15egan
Copy link
Collaborator

tw15egan commented Aug 1, 2019

@tw15egan tw15egan closed this as completed Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants