docs(tooltip): revert to peviously correct stories, use help icon #18245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18245 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 404 404
Lines 14350 14350
Branches 4649 4649
=======================================
Hits 12077 12077
Misses 2112 2112
Partials 161 161 ☔ View full report in Codecov by Sentry. |
tay1orjones
requested review from
a team,
alina-jacob and
aagonzales
and removed request for
a team and
alina-jacob
aagonzales
approved these changes
Dec 11, 2024
ariellalgilmore
approved these changes
Dec 11, 2024
alisonjoseph
approved these changes
Dec 11, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 11, 2024
181f38f
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #17006, this reverts the tooltip stories back to correct examples that use the help icon instead of the information icon (which previously created confusion)
Related:
Tooltip&DefinitionTooltipchanged storybook and functionality #15887Changelog
Changed
Testing / Reviewing