docs(tooltip): use Button instead of Information icons in stories #17006
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
These changes look like an improvement to me, but I think the other issue (according to Michael Gower) is to update https://carbondesignsystem.com/components/tooltip/usage/#standard-tooltip to say that "standard tooltips" should be displayed using Toggletip. Right now it says:
If the content is essential for the user to interpret concerning their workflow, use a toggletip for this information instead.
Actually it seems like you should replace all the text to say "Informational tooltip" wherever it now says "Standard tooltip"?
|
@wkeese Cool, yeah this is just the actionable piece for the storybook since the website repo is separate. @kingtraceyj could you share the issue that is tracking the website updates you mentioned? |
There was a problem hiding this comment.
Hey @tay1orjones
The SquareOutline is not defined in the import, I guess that's why the stories are all blank https://deploy-preview-17006--v11-carbon-react.netlify.app/?path=/story/components-tooltip--playground
The FormLabel looks good to me!
There was a problem hiding this comment.
@tay1orjones The stories doesn't have the <Information /> icon anymore.
I added the <Information /> back in to test the code locally and the focus looks weird.
<Tooltip align="bottom" label={label}>
<Button className="sb-tooltip-trigger">
<Information />
</Button>
</Tooltip>
|
@guidari sorry for the back and forth here, I need to update the tooltip styling and correct a few other things. I think that specific focus ring issue could be solved by adding |
|
@tay1orjones I think you'll need to remove the custom styles to fix the weird display of the button in the Tooltip story. Wasn't sure if there was anything else that needed to be done with this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17006 +/- ##
==========================================
+ Coverage 82.19% 82.23% +0.04%
==========================================
Files 404 404
Lines 14151 14184 +33
Branches 4418 4505 +87
==========================================
+ Hits 11631 11664 +33
+ Misses 2359 2358 -1
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
@alisonjoseph thanks for the heads up! I updated it - this should be ready now |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
3aa7596
|
Hey there! v11.71.0 was just released that references this issue/PR. |
A small detail of #12921, carbon-design-system/carbon-design-kit#721, #15887 that was missed, this PR modifies the Tooltip storybook examples to use a button as the trigger to avoid confusion stemming from information icons.
Related to carbon-design-system/carbon-website#3956
Changelog
Changed
Removed
Testing / Reviewing