-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y]: Tooltip examples and behaviour need to be updated #12921
Comments
@sstrubberg IMO issues 4 and 5 should be treated as higher severity. |
@mbgower Any chance you could break issues 4 and 5 into separate tickets that we can triage and prioritize against a sprint? Also happy to have you come back to refinement so we can do it together :) |
@sstrubberg Happy to. Can you please add me to invite |
Blocked until we handle carbon-design-system/carbon-website#3332 |
Addressing mentioned above items
|
We've updated the live demo on the website, so I crossed out the first two items in the list. |
So |
Package
@carbon/react
Browser
Chrome
Operating System
MacOS
Package version
https://react.carbondesignsystem.com/?path=/story/components-tooltip--default
React version
No response
Automated testing tool and ruleset
n/a
Assistive technology
No response
Description
The interaction of various tip examples is inconsistent and contradictory between tooltip and toggletip..
1) The Live demo example on the usage page makes no sense. When the focus lands on the i icon, nothing happens. Then I tab again, and focus remains on the 'i' and suddenly it has a tip. Focus should immediately trigger thte tip to appear.2) In the same Live demo section, changing the Variant selector to be definition tooltip also shows an implementation problem. The definition never appears on focus/hover but instead appears exclusively on click/activate. It is implemented as a TOGGLETIP instead of as a tooltip.3) In storybook, the definition tooltip is under its own "D" heading instead of being under tooltip. It is less likely to be discovered there, and should be under tooltip, as is the case with variants of other components
4) Further the definition tooltip is again implemented as a toggletip instead of a tooltip. The difference in behaviour makes no sense. As mentioned in carbon-design-system/carbon-website#3332, the definition tooltip should always expose on hover/focus.
5) The playground for tooltip has the tooltip appearing before it has focus. Same for the playground for the definition tooltip. This should obviously not be happening
6) As mentioned in the website issue, all the uses of the information icon ('i') for tooltips should be expunged from the storybook and from the Figma kits
7) A challenge for Carbon is that while the tooltip component has a requirement for text, the icon-only button does not, nor does the ghost button, yet they both need a tooltip to provide context. So guidance in both Carbon and storybook and in Figman's buttons should be revamped so that the label/name attribute is populated -- except in some very limited cases where there is a reason that the tip should not be exposed on focus/hover.
Tasks
WCAG 2.1 Violation
No response
Reproduction/example
https://carbondesignsystem.com/components/tooltip/usage#live-demo
Steps to reproduce
Go to both the live demo and the storybook examples
Using a keyboard
Code of Conduct
The text was updated successfully, but these errors were encountered: