Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unique id to name in TableSelectRow #17015

Merged
merged 7 commits into from
Jul 24, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jul 22, 2024

Closes #16843

By adding a unique id to name it allow the user to use multiple datatable with selection without any issue.
This fix doesn't impact the fix made in this PR

Example not working when name is not passed: https://stackblitz.com/edit/github-rjvrvh-qjguva?file=src%2FApp.jsx

Changelog

New

  • Added unique id to name in TableSelectRow

Testing / Reviewing

Check for any regressions in the Selection variant for Datatable

  • Remove Test story
Screen.Recording.2024-07-22.at.16.14.44.mov

@guidari guidari requested a review from a team as a code owner July 22, 2024 19:22
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2662054
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66a159506a5adc00089aa9b5
😎 Deploy Preview https://deploy-preview-17015--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2662054
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66a159506442d900075b0b05
😎 Deploy Preview https://deploy-preview-17015--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@preetibansalui preetibansalui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its failing few of the test checks, please fix them, otherwise it looks Good.

riddhybansal

This comment was marked as duplicate.

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (don't forget to remove test story)

@guidari guidari added this pull request to the merge queue Jul 24, 2024
Merged via the queue into carbon-design-system:main with commit 4bdf29d Jul 24, 2024
22 checks passed
@guidari guidari deleted the 16843-datatable branch July 24, 2024 20:15
@wkeese
Copy link
Contributor

wkeese commented Aug 2, 2024

This broke everyone on React 16 and React 17, because those versions of React don't support useId(). You should be importing the polyfill like this instead:

import { useId } from '../../internal/useId.js';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DataTable with radio selection breaks when there are 2+ radio DataTables in DOM
7 participants