-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unique id to name
in TableSelectRow
#17015
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its failing few of the test checks, please fix them, otherwise it looks Good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (don't forget to remove test story)
4bdf29d
This broke everyone on React 16 and React 17, because those versions of React don't support
|
Closes #16843
By adding a unique id to
name
it allow the user to use multiple datatable with selection without any issue.This fix doesn't impact the fix made in this PR
Example not working when
name
is not passed: https://stackblitz.com/edit/github-rjvrvh-qjguva?file=src%2FApp.jsxChangelog
New
name
inTableSelectRow
Testing / Reviewing
Check for any regressions in the Selection variant for Datatable
Screen.Recording.2024-07-22.at.16.14.44.mov