-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DataTable): don't set unique name for each radio input #14644
fix(DataTable): don't set unique name for each radio input #14644
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6edf30d
to
6a4fdd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arrow keys work great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Closes #14268
Fixes an issue that was preventing a user from navigating a Radio selection
DataTable
with the arrow keys. Since each radio button had aname
appended with the row id, it assumed they were all in their own groups. Now, they all get the same name for each table. If a user has multiple radio tables, they would just need to pass in their ownname
prop toTableSelectRow
after thegetSelectionProps
Changelog
Changed
name
Testing / Reviewing
Go to
DataTable --> Selection --> With Radio
and ensure you can navigate theDataTable
with the arrow keys