fix(DataTable): don't set unique name for each radio input (#14644)

* fix(DataTable): don't set unique name for each radio input * test(DataTable): update snapshots * fix(DataTable): build with latest icons
carbon-design-system · Sep 14, 2023 · 47ff517 · 47ff517
1 parent 1cb7cd7
commit 47ff517
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/packages/react/src/components/DataTable/DataTable.tsx b/packages/react/src/components/DataTable/DataTable.tsx
@@ -632,7 +632,7 @@ class DataTable<RowType, ColTypes extends any[]> extends React.Component<
           onClick,
         ]),
         id: `${this.getTablePrefix()}__select-row-${row.id}`,
-        name: `select-row-${row.id}`,
+        name: `select-row`,
         ariaLabel: t(translationKey),
         disabled: row.disabled,
         radio: this.props.radio || null,

diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
@@ -61,7 +61,7 @@ exports[`DataTable behaves as expected selection -- radio buttons should not hav
                 <input
                   class="cds--radio-button"
                   id="data-table-17__select-row-b"
-                  name="select-row-b"
+                  name="select-row"
                   type="radio"
                   value=""
                 />
@@ -97,7 +97,7 @@ exports[`DataTable behaves as expected selection -- radio buttons should not hav
                 <input
                   class="cds--radio-button"
                   id="data-table-17__select-row-a"
-                  name="select-row-a"
+                  name="select-row"
                   type="radio"
                   value=""
                 />
@@ -133,7 +133,7 @@ exports[`DataTable behaves as expected selection -- radio buttons should not hav
                 <input
                   class="cds--radio-button"
                   id="data-table-17__select-row-c"
-                  name="select-row-c"
+                  name="select-row"
                   type="radio"
                   value=""
                 />
@@ -227,7 +227,7 @@ exports[`DataTable behaves as expected selection -- radio buttons should render
                 <input
                   class="cds--radio-button"
                   id="data-table-16__select-row-b"
-                  name="select-row-b"
+                  name="select-row"
                   type="radio"
                   value=""
                 />
@@ -263,7 +263,7 @@ exports[`DataTable behaves as expected selection -- radio buttons should render
                 <input
                   class="cds--radio-button"
                   id="data-table-16__select-row-a"
-                  name="select-row-a"
+                  name="select-row"
                   type="radio"
                   value=""
                 />
@@ -299,7 +299,7 @@ exports[`DataTable behaves as expected selection -- radio buttons should render
                 <input
                   class="cds--radio-button"
                   id="data-table-16__select-row-c"
-                  name="select-row-c"
+                  name="select-row"
                   type="radio"
                   value=""
                 />
@@ -675,7 +675,7 @@ exports[`DataTable behaves as expected selection should render and match snapsho
                 <input
                   class="cds--checkbox"
                   id="data-table-7__select-row-b"
-                  name="select-row-b"
+                  name="select-row"
                   type="checkbox"
                 />
                 <label
@@ -707,7 +707,7 @@ exports[`DataTable behaves as expected selection should render and match snapsho
                 <input
                   class="cds--checkbox"
                   id="data-table-7__select-row-a"
-                  name="select-row-a"
+                  name="select-row"
                   type="checkbox"
                 />
                 <label
@@ -739,7 +739,7 @@ exports[`DataTable behaves as expected selection should render and match snapsho
                 <input
                   class="cds--checkbox"
                   id="data-table-7__select-row-c"
-                  name="select-row-c"
+                  name="select-row"
                   type="checkbox"
                 />
                 <label