Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: @carbon/react 1.63.0 breaks React 17 compatibility #17095

Closed
2 tasks done
wkeese opened this issue Aug 2, 2024 · 2 comments
Closed
2 tasks done

[Bug]: @carbon/react 1.63.0 breaks React 17 compatibility #17095

wkeese opened this issue Aug 2, 2024 · 2 comments

Comments

@wkeese
Copy link
Contributor

wkeese commented Aug 2, 2024

Package

@carbon/react

Browser

Chrome

Package version

1.63.0

React version

17

Description

PR #17015 breaks React 17 compatibility by directly referencing Carbon's used() in TableSelectRow.tsx

TableSelectRow.tsx should be importing the polyfill like this instead:

import { useId } from '../../internal/useId.js';

Note that Carbon 11 claims to support React 17, see https://github.com/carbon-design-system/carbon/blob/main/packages/react/package.json#L44.

Reproduction/example

https://react.carbondesignsystem.com/?path=/story/components-datatable-selection--default

Steps to reproduce

Build against React 17 and run app

Suggested Severity

None

Application/PAL

WXD

Code of Conduct

@gi
Copy link
Contributor

gi commented Aug 5, 2024

#17098 should have fixed the useId issue

@wkeese
Copy link
Contributor Author

wkeese commented Aug 12, 2024

Thanks, looks good, I see the fix in 1.63.2.

@wkeese wkeese closed this as completed Aug 12, 2024
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants