react: fix usage of useId #17098
Merged
react: fix usage of useId #17098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
preetibansalui
approved these changes
Aug 5, 2024
|
Fix for #17095 |
tay1orjones
approved these changes
Aug 5, 2024
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Aug 5, 2024
e963ee5
22 checks passed
2 tasks
tay1orjones
added a commit
to tay1orjones/carbon
that referenced
this pull request
Aug 9, 2024
* fix(TableSelectRow): import useId from internal polyfill * fix(TableToolbarSearch): pass prefix to useId to avoid null --------- Co-authored-by: Taylor Jones <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a couple of react package components and their usage of the
useIdfunction.Changelog
Changed
TableSelectRow: importuseIdfrom internal polyfill package instead of directly from ReactTableToolbarSearch: pass prefix touseIdto avoid null valueTesting / Reviewing
Existing unit tests