fix(combobox): correct behavior of selection onChange with filtered items #16835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am not sure but I could not see the deploy preview for this PR 😮 |
|
@riddhybansal not sure why the deploy preview didn't post a github comment, but you can click the link directly from the checks on the PR. |
alisonjoseph
approved these changes
Jun 21, 2024
guidari
approved these changes
Jun 21, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jun 21, 2024
22dea80
42 checks passed
tay1orjones
added a commit
to tay1orjones/carbon
that referenced
this pull request
Jun 21, 2024
…tems (carbon-design-system#16835) * fix(combobox): onChange returns the proper item with shouldFilterItem * WIP * fix(combobox): use filterItems for items * fix(combobox): correct selection when filtered items
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16630
Closes #16829
This corrects selection and onChange behavior when the listbox items are filtered and one is selected.
Changelog
New
cognateItemsto help test the partial search functionality in ComboboxChanged
filterItems()instead of using the baseitemsTesting / Reviewing
applepineapple- selection should be correct, onChange in the actions pane should fire once with the proper value