Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): correct onChange when shouldFilterItem on filtered items #16802

Closed

Conversation

preetibansalui
Copy link
Contributor

@preetibansalui preetibansalui commented Jun 17, 2024

Closes #16630
Closes #16829

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit bcb8b08
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66748ce96fe43200087de8d8
😎 Deploy Preview https://deploy-preview-16802--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bcb8b08
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66748ce94fc7f500083df8be
😎 Deploy Preview https://deploy-preview-16802--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@preetibansalui preetibansalui marked this pull request as ready for review June 17, 2024 14:51
@preetibansalui preetibansalui requested a review from a team as a code owner June 17, 2024 14:51
@preetibansalui preetibansalui marked this pull request as draft June 18, 2024 07:14
@tay1orjones tay1orjones changed the title 16630 combobox fix fix(combobox): correct onChange when shouldFilterItem on filtered items Jun 20, 2024
@tay1orjones
Copy link
Member

Closed in favor of #16835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants