You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes#16381 - TextArea and TextInput Closes#16383 - ToolTip Closes#16384 - TileGroup and UnorderedList
Exporting the typescript props for the above mentioned components as part of typescript adoption
(This PR is mentioned as 2, as we have more components where props needs to be exported so there will be more PRs regarding this)
Changelog
Changed
exporting interfaces from the .tsx files if not done
Importing them to index.ts and exporting them explicitly so that users can import them directly with the component.
Testing / Reviewing
No changes to the component, so new testing observations.
Should this PR also include the import and export for TextInputSkeletonProps in packages/react/src/components/TextInput/index.ts? I was looking at this issue #16382 and I assume this PR would also have a fix to include the TextInputSkeletonProps in the index.ts file. Thanks!
Should this PR also include the import and export for TextInputSkeletonProps in packages/react/src/components/TextInput/index.ts? I was looking at this issue #16382 and I assume this PR would also have a fix to include the TextInputSkeletonProps in the index.ts file. Thanks!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
Main issue: #16154
Closes #16381 -
TextAreaandTextInputCloses #16383 -
ToolTipCloses #16384 -
TileGroupandUnorderedListExporting the typescript props for the above mentioned components as part of typescript adoption
(This PR is mentioned as 2, as we have more components where props needs to be exported so there will be more PRs regarding this)
Changelog
Changed
Testing / Reviewing
No changes to the component, so new testing observations.