Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export typescript props for TabProps #16380

Closed
Tracked by #16154
riddhybansal opened this issue May 9, 2024 · 6 comments
Closed
Tracked by #16154

Export typescript props for TabProps #16380

riddhybansal opened this issue May 9, 2024 · 6 comments
Assignees
Labels
component: tabs severity: 3 https://ibm.biz/carbon-severity

Comments

@riddhybansal
Copy link
Contributor

riddhybansal commented May 9, 2024

linking issue for #16154

@Gururajj77 Gururajj77 changed the title TabProps Export typescript props for TabProps May 13, 2024
@Gururajj77 Gururajj77 self-assigned this May 13, 2024
@Gururajj77 Gururajj77 closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in Design System May 13, 2024
@Gururajj77
Copy link
Contributor

closed as this is completed previously.

@kenneth-nguyen1
Copy link

Hi @Gururajj77, where was this task completed?

I do not see TabProps (https://github.com/carbon-design-system/carbon/blob/main/packages/react/src/components/Tabs/Tabs.tsx#L739) being imported and exported from /components/Tabs/index.tsx nor /components/Tab/index.tsx on the carbon main branch and can't find an open or closed PR for this being completed.

@Gururajj77 Gururajj77 reopened this May 17, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to ⏱ Backlog in Design System May 17, 2024
@Gururajj77
Copy link
Contributor

Thank you, @kenneth-nguyen1, for pointing that out! I appreciate your attention to detail. I'll make sure to export TabProps as well. Initially, I had excluded the component since TabsProps was already being exported. Your feedback is very helpful!

@kenneth-nguyen1
Copy link

Thank you, much appreciated!

@Gururajj77
Copy link
Contributor

Hey @kenneth-nguyen1 , have added export for TabProps now, you can track the progress on this PR, #16448.

@Gururajj77 Gururajj77 moved this from ⏱ Backlog to 🚦 In Review in Design System May 17, 2024
@Gururajj77
Copy link
Contributor

closed with #16448

@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs severity: 3 https://ibm.biz/carbon-severity
Projects
Archived in project
Development

No branches or pull requests

3 participants