feat: export props for accordion #16284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
requested changes
May 1, 2024
There was a problem hiding this comment.
We probably should be as explicit as possible with both the imports and exports.
Do you think we could batch all the other ones into one PR or would you prefer to do separate ones for each listed in #16154
Also see my note over there: #16154 (comment) - I think the expectation here for now is that we'll only be able to make these available through fully qualified import paths, e.g.
import { type AccordionProps } from "@carbon/react/es/components/Accordion";
Does that match what you've understood so far here working on this? Maybe I'm incorrect.
| @@ -5,9 +5,10 @@ | |||
| * LICENSE file in the root directory of this source tree. | |||
| */ | |||
|
|
|||
| import Accordion from './Accordion'; | |||
| import Accordion, { AccordionProps } from './Accordion'; | |||
There was a problem hiding this comment.
Suggested change
| import Accordion, { AccordionProps } from './Accordion'; | |
| import Accordion, { type AccordionProps } from './Accordion'; |
Comment on lines
11
to
+12
| export { Accordion }; | ||
| export type { AccordionProps }; |
There was a problem hiding this comment.
Suggested change
| export { Accordion }; | |
| export type { AccordionProps }; | |
| export { Accordion, type AccordionProps }; |
tay1orjones
added
role: dev 🤖
area: typescript
type: infrastructure 🤖
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16154
Created a Draft PR to get the export reviewed
Changelog
Changed