feat: exporting typescript props for various components - 1 #16447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gururajj77
changed the title
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
2nikhiltom
approved these changes
May 14, 2024
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
May 21, 2024
guidari
approved these changes
May 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a manual request
|
@Gururajj77 Looks like the PR got closed for some reason. I'm gonna re-open and try to merge it again |
Merged
via the queue into
carbon-design-system:main
with commit May 21, 2024
111db86
21 checks passed
|
Hey there! v11.58.0 was just released that references this issue/PR. |
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main issue #16154
Closes #16373 -
InlineLoadingPropsCloses #16374 -
LoadingPropsCloses #16375 -
ModalPropsCloses #16376 -
NumberInputPropsCloses #16377 -
ProgressBarandProgressIndicatorExporting the typescript props for the above mentioned components as part of typescript adoption
(This PR is mentioned as 1, as we have more components where props needs to be exported so there will be more PRs regarding this)
Changelog
Changed
.tsxfiles if not doneindex.tsand exporting them explicitly so that users can import them directly with the component.Labelin theNumberInputasFCcomponent as typescript wasn't recognising it as component and due to this, propTypes was throwing error while build.Testing / Reviewing
No changes to the component, so new testing observations.