Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): add text direction auto/ltr/rtl switcher #14464

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

tay1orjones
Copy link
Member

Closes #13620

This PR improves our storybook toolbar to have a Text direction toolbar item that influences the dir attribute on the html element that wraps the story.

image

Changelog

New

  • Add a Text direction toolbar item to storybook

Changed

  • Provide a title for our custom toolbar items in storybook to prevent confusion and improve discoverability
  • add dev :: prefix for toolbar items that are only visible in dev

Testing / Reviewing

  • Go to a tile story, select rtl or ltr.
  • The component should reflow to display properly when rtl vs ltr is selected thanks to recent work in fix(tile): support rtl direction #14441
  • Other components that have been updated to use logical properties should also render appropriately as it switches.

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 0f52c98
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64dfc58cdd36920008ee2043
😎 Deploy Preview https://deploy-preview-14464--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0f52c98
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64dfc58c5a692900079454c9
😎 Deploy Preview https://deploy-preview-14464--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good! So cool 😎

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thanks for adding this!

@github-actions github-actions bot added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 23, 2023
@tw15egan tw15egan added this pull request to the merge queue Aug 23, 2023
Merged via the queue into carbon-design-system:main with commit a812553 Aug 23, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Right-to-left (RTL) mode/toggle in storybook
4 participants