Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Right-to-left (RTL) mode/toggle in storybook #13620

Closed
1 task done
Tracked by #14477
tay1orjones opened this issue Apr 18, 2023 · 2 comments · Fixed by #14464
Closed
1 task done
Tracked by #14477

Provide Right-to-left (RTL) mode/toggle in storybook #13620

tay1orjones opened this issue Apr 18, 2023 · 2 comments · Fixed by #14464
Assignees
Labels
adopter: strategic-product Work-stream that directly effects the Product-led Growth initiative. proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: bidi ↔️ type: enhancement 💡
Milestone

Comments

@tay1orjones
Copy link
Member

The problem

There's currently no way to easily change the direction of the storybook canvas to test or view components in rtl mode.

The solution

Provide a way to toggle rtl mode within the storybook canvas. It shouldn't impact the rest of the page.

Before we can do this we either need to run the styles through RTLCSS and include them in storybook or wait until we've refactored to use CSS Logical Properties and Values #13619

Examples

There's some addons out there, but nothing officially from storybook. We might consider using one of these or rolling our own if we find it doesn't work as we'd like.

Application/PAL

No response

Business priority

None

Available extra resources

No response

Code of Conduct

@github-project-automation github-project-automation bot moved this to Triage in Roadmap Apr 18, 2023
@tay1orjones tay1orjones changed the title [Feature Request]: Provide Right-to-left (RTL) mode/toggle in storybook Provide Right-to-left (RTL) mode/toggle in storybook Apr 18, 2023
@tay1orjones tay1orjones added adopter: strategic-product Work-stream that directly effects the Product-led Growth initiative. proposal: accepted This request has gone through triaging and we are accepting PR's against it. labels Apr 18, 2023
@sstrubberg sstrubberg moved this from Triage to Later in Roadmap May 9, 2023
@tay1orjones
Copy link
Member Author

This is blocked by #13619

@tay1orjones
Copy link
Member Author

While it initially made sense to do #13619 first, I'm realizing that as we implement the logical properties over time, it would be nice if we could more easily test rtl with this switcher now vs later once all the components are migrated to use logical properties.

So I wouldn't consider this blocked anymore

@tay1orjones tay1orjones self-assigned this Aug 18, 2023
@tay1orjones tay1orjones moved this from Later to Now in Roadmap Aug 18, 2023
@tay1orjones tay1orjones moved this to 🏗 In Progress in Design System Aug 18, 2023
@tay1orjones tay1orjones added this to the 2023 Q3 milestone Aug 18, 2023
@tay1orjones tay1orjones moved this from 🏗 In Progress to 🚦 In Review in Design System Aug 18, 2023
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Aug 23, 2023
@github-project-automation github-project-automation bot moved this from Now to Completed in Roadmap Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: strategic-product Work-stream that directly effects the Product-led Growth initiative. proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: bidi ↔️ type: enhancement 💡
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant