Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tile): support rtl direction #14441

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

janhassel
Copy link
Member

@janhassel janhassel commented Aug 15, 2023

Part of #13619

Adds support for right-to-left to Tile component.

Example: RadioTile

Before
image

After
image

Changelog

Changed

  • Updated top, right, bottom, left to respective css logical properties

Testing / Reviewing

  1. Add dir="rtl" to the root html tag in storybook
  2. Test all Tile stories (incl. experimental ones)

@janhassel janhassel requested a review from a team as a code owner August 15, 2023 16:03
@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5bc09f0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64dcacd780d99c000758cb13
😎 Deploy Preview https://deploy-preview-14441--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5bc09f0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64dcacd7e01e7400080982b5
😎 Deploy Preview https://deploy-preview-14441--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text on expandable doesn't appear to be adjusting to the change. The button is properly positioned though

https://deploy-preview-14441--carbon-components-react.netlify.app/?path=/story/components-tile--expandable

image

@janhassel
Copy link
Member Author

@tay1orjones Good catch! I just pushed an update to fix it.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested at different breakpoints - looks good to me 🎉 !!

@andreancardona andreancardona added this pull request to the merge queue Aug 16, 2023
Merged via the queue into carbon-design-system:main with commit 8f2ab5f Aug 16, 2023
16 checks passed
@janhassel janhassel deleted the tile-rtl branch August 17, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants