fix(ListBoxMenuItem): ensure border-subtle renders correct value #13879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
force-pushed
the
border-subtle-layer-dropdown
branch
from
8b94e40 to
d4d16fb
Compare
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tw15egan
force-pushed
the
border-subtle-layer-dropdown
branch
from
50b5aab to
e8b7f80
Compare
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tw15egan
force-pushed
the
border-subtle-layer-dropdown
branch
from
b7d5c35 to
d7814f0
Compare
aagonzales
approved these changes
Jun 16, 2023
|
Looks like there is still an issue with |
tay1orjones
approved these changes
Jun 20, 2023
tw15egan
force-pushed
the
border-subtle-layer-dropdown
branch
from
d7814f0 to
6ed82a5
Compare
tw15egan
added
status: ready to merge 🎉
and removed
DO NOT MERGE
status: ready for review 👀
labels
|
Hey there! v11.32.0 was just released that references this issue/PR. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aagonzales mention on Slack that the Dropdown / Combobox / Multiselect
$border-subtlevalues were off. It's because the menus themselves render one level higher on thelayerscale (01) , butborder-subtlewas still calculating to its base level (00). This change scopes allListBoxMenuItemstyles to their appropriate value, based on the presence ofcds--layer-twoorcds--layer-three, and defaults toborder-subtle-01if not. I searched for all$border-subtleinstances and added a block for each of the two layers, and cleaned up some styles issues that were present with the change in color of these new borders.Changelog
Changed
$border-subtleto reference the layer directly i.e$border-subtle-01Testing / Reviewing
Check out the
Dropdown,Combobox,Multiselectand otherwithLayerstories that utilizeborder-subtleand ensure values remain correct. THis mainly affects the menu items that appear when the menu is open, and when hovering them. This should only affect components that useListBoxMenuItem.