Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Data table border-subtle is off by a layer #17454

Closed
2 tasks done
aagonzales opened this issue Sep 16, 2024 · 3 comments · Fixed by #17548
Closed
2 tasks done

[Bug]: Data table border-subtle is off by a layer #17454

aagonzales opened this issue Sep 16, 2024 · 3 comments · Fixed by #17548
Assignees
@ziyadzulfikar
Labels
component: structured-list package: @carbon/react @carbon/react role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@aagonzales
Copy link
Member

Package

@carbon/react

Browser

Chrome

Package version

v1.66.0

React version

No response

Description

The layer structure for the border-subtles in data table is off by one. It should start at $border-subtle-01 instead of $border-subtle-02 Similar problem to what was fixed in #13879.

image

Reproduction/example

n/a

Steps to reproduce

Open up the data table example in storybook and switch to the Gray 10 theme. The border color that appears on the white table is too dark.

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

Core but Cloud brought this to my attention

Code of Conduct
@alina-jacob alina-jacob moved this to ⏱ Backlog in Design System Sep 17, 2024
@alina-jacob alina-jacob added severity: 3 https://ibm.biz/carbon-severity role: dev 🤖 package: @carbon/react @carbon/react labels Sep 17, 2024
@ziyadzulfikar
Copy link
Contributor

Hi @alina-jacob,

If this issue is still open, I’d like to work on it. Could you please assign it to me. Thanks!

@ziyadzulfikar ziyadzulfikar mentioned this issue Sep 22, 2024
Merged
@ziyadzulfikar
Copy link
Contributor

ziyadzulfikar commented Sep 23, 2024 •
edited
Loading

@alina-jacob @guidari Could you please have a look on the PR that I have raised?

@ziyadzulfikar
Copy link
Contributor

@alina-jacob @guidari The fix has already been implemented in the above PR. Could someone please review it?

@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ziyadzulfikar ziyadzulfikar

Labels
component: structured-list package: @carbon/react @carbon/react role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(styles): update border-block-end to use $border-subtle-01 ziyadzulfikar/carbon
4 participants
@aagonzales @guidari @ziyadzulfikar @alina-jacob