Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): update border-block-end to use $border-subtle-01 #17548

Merged
merged 9 commits into from
Oct 21, 2024

Conversation

ziyadzulfikar
Copy link
Contributor

Closes #17454

Updated the border-block-end of each element in the table rows.

Changelog

Changed

  • Changed border-block-end: 1px solid $border-subtle; to border-block-end: 1px solid $border-subtle-01;

Testing / Reviewing

  • Navigate to the DataTable component's playground story.

  • Review the styling of the <td> elements in the table rows that use the border-block-end property, and ensure the values are applied correctly and consistently.

@ziyadzulfikar ziyadzulfikar requested a review from a team as a code owner September 22, 2024 07:33
Copy link
Contributor

github-actions bot commented Sep 22, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 07d133d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/671653f4327f920008db5f01
😎 Deploy Preview https://deploy-preview-17548--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 07d133d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/671653f4b2a07300083be311
😎 Deploy Preview https://deploy-preview-17548--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ziyadzulfikar
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! There is one small piece still needed though, see below

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You just have to fix some merge conflicts

@ziyadzulfikar
Copy link
Contributor Author

@guidari
I have resolved the conflicts.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.15%. Comparing base (f2c4993) to head (07d133d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17548   +/-   ##
=======================================
  Coverage   80.15%   80.15%           
=======================================
  Files         406      406           
  Lines       14011    14011           
  Branches     4332     4384   +52     
=======================================
  Hits        11231    11231           
+ Misses       2614     2613    -1     
- Partials      166      167    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guidari
Copy link
Contributor

guidari commented Oct 14, 2024

Hey, I'm checking Percy and seems like this changes triggers an error in Datatable story with expansion. The line it is not complete

Screenshot 2024-10-14 at 10 31 21

@ziyadzulfikar
Copy link
Contributor Author

@guidari This issue has been fixed.

Hey, I'm checking Percy and seems like this changes triggers an error in Datatable story with expansion. The line it is not complete

Screenshot 2024-10-14 at 10 31 21

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 07d133d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/671653f476c82f00089f8988
😎 Deploy Preview https://deploy-preview-17548--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari
Copy link
Contributor

guidari commented Oct 17, 2024

Cool! Percy LGTM!
It is just missing @tay1orjones review now!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tay1orjones tay1orjones added this pull request to the merge queue Oct 21, 2024
Merged via the queue into carbon-design-system:main with commit e667c88 Oct 21, 2024
39 of 40 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.69.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Data table border-subtle is off by a layer
4 participants