Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Modal): ensure dropdown menu layer is correct #14303

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

tw15egan
Copy link
Collaborator

Closes #13698
Refs #13258
Refs #13879

Ensures all listbox menus render the correct background color

Changelog

Changed

  • Aligned menu tokens with the appropriate layer token (scope inside modal)

Testing / Reviewing

Ensure Dropdown renders the correct menu background when open

@tw15egan tw15egan requested a review from a team as a code owner July 25, 2023 15:44
@tw15egan tw15egan requested review from alisonjoseph and guidari July 25, 2023 15:44
@tw15egan tw15egan requested review from a team and laurenmrice and removed request for a team July 25, 2023 15:45
@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 6ce65b5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64c95755c92f2c0008d2bef1
😎 Deploy Preview https://deploy-preview-14303--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6ce65b5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64c9575594cd75000835615f
😎 Deploy Preview https://deploy-preview-14303--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check to see what the other state color tokens are for the options in the dropdown inside of the modal? For the dark themes it looks like the hover and selected states are wrong.
Gray 100

@tw15egan
Copy link
Collaborator Author

@laurenmrice just added some more overrides to enforce those specific styles 👍🏻

@tw15egan tw15egan requested a review from laurenmrice August 4, 2023 18:59
@tw15egan tw15egan added this pull request to the merge queue Aug 7, 2023
Merged via the queue into carbon-design-system:main with commit 379ea23 Aug 7, 2023
@tw15egan tw15egan deleted the modal-dropdown-layer branch August 7, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dropdown & Fluid inputs inside modal - wrong background-color token
4 participants