Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aria-labelledby in ComposeDialog in order to handle accessibility violation #7824

Closed
ghost opened this issue Feb 17, 2021 · 3 comments · Fixed by #7825
Closed

Support aria-labelledby in ComposeDialog in order to handle accessibility violation #7824

ghost opened this issue Feb 17, 2021 · 3 comments · Fixed by #7825

Comments

@ghost
Copy link

ghost commented Feb 17, 2021

This is a follow-up for #6543.
The current fix introduced support for aria-label and some computation to re-use label from ModalHeader.

Environment

MacOS, Chrome

Assistive technology used to verify
IBM Equal Access Accessibility Checker

Detailed description

What version of the Carbon Design System are you using?

"carbon-components": "10.28.0",
"carbon-components-react": "7.27.0",

What did you expect to happen?

One of possible solutions for "Interactive component does not have a programmatically associated name" is "Use the aria-labelledby attribute to reference existing visible text on the page that can clearly identify the purpose of the component"

Steps to reproduce the issue

Steps are the same as for #6543
Setting aria-labelledby on ComposeDialog does not fix the violation.

@ghost ghost added the type: a11y ♿ label Feb 17, 2021
@ghost
Copy link
Author

ghost commented Feb 17, 2021

I have PR created. I am sending it for the review in couple minutes.

@ghost ghost changed the title Support arialabelled-by in ComposeDialog in order to handle accessibility violation Support aria-labelledby in ComposeDialog in order to handle accessibility violation Feb 17, 2021
@tw15egan
Copy link
Collaborator

@szymonbrandys do you have a link to a reproducible example that is throwing this a11y violation?

@tw15egan
Copy link
Collaborator

@kodiakhq kodiakhq bot closed this as completed in #7825 Feb 19, 2021
kodiakhq bot added a commit that referenced this issue Feb 19, 2021
accessibility violation #7824

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants