Support aria-labelledby in ComposeDialog in order to handle accessibility violation #7825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
changed the title
accessibility violation #7824
|
Deploy preview for carbon-elements ready! Built with commit b12b1b1 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit b12b1b1 https://deploy-preview-7825--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit d67ae88 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit d67ae88 https://deploy-preview-7825--carbon-components-react.netlify.app |
joshblack
approved these changes
Feb 19, 2021
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7824
Fixes a11y issues with ComposedModal
Changelog
New
Testing / Reviewing
Ensure there are no a11y violations with Composed Modal when aria-labelledby is used.