Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon Compose Modal accessibility violation #6543

Closed
bryan-pegg23 opened this issue Jul 24, 2020 · 3 comments · Fixed by #7609
Closed

Carbon Compose Modal accessibility violation #6543

bryan-pegg23 opened this issue Jul 24, 2020 · 3 comments · Fixed by #7609

Comments

@bryan-pegg23
Copy link

Detailed description

experiencing same/similar issue that was in ticket #4587. An interactive element/widget must have an accessible name. violation is thrown on top level of compose modal component. can be seen in both sample application below and in story book here https://react.carbondesignsystem.com/?path=/story/composedmodal--example-usage-with-trigger-button

What version of the Carbon Design System are you using?

  • versions, also found in codesandbox:
    "carbon-components": "10.16.0",
    "carbon-components-react": "7.16.0",
    "carbon-icons": "7.0.7",
    "react": "16.3.1",
    "react-dom": "16.3.1",

What did you expect to happen?

  • no accessibility violations

What WCAG 2.1 checkpoint does the issue violate?

https://aat.w3ibm.mybluemix.net/token/4950d599-abf0-4c72-b249-9eed7e3bf02e/82ec2f72-e53b-4c22-98b3-faab6bd311db/archives/2020JanDeploy//doc/w3/help/en-US/idhi_accessibility_check_g1156.html

Please create a reduced test case in CodeSandbox
https://codesandbox.io/s/carbon-components-react-du1ip?file=/src/index.js

Additional information

Screen Shot 2020-07-24 at 9 21 44 AM

@emyarod
Copy link
Member

emyarod commented Aug 4, 2020

the error doesn't seem to be present on https://carbon-components-react.netlify.com/?path=/story/composedmodal--example-usage-with-trigger-button which is the latest version of the component

@emyarod emyarod removed their assignment Aug 17, 2020
@dakahn
Copy link
Contributor

dakahn commented Sep 1, 2020

I'm seeing this error using Accessibility Checker with latest ruleset.
image.png

The modal needs an accessible name or title of some kind as seen in this WAI-Aria example
image.png

@dhyliu
Copy link

dhyliu commented Jan 5, 2021

@dakahn Hello! This issue was opened around 4 months ago. Could I have your support to close it asap? It is now a blocker for several offerings on IBM Cloud to GA launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants