Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ComposedModal): add accessible name and aria-label prop #7609

Merged
merged 5 commits into from
Jan 27, 2021
Merged

fix(ComposedModal): add accessible name and aria-label prop #7609

merged 5 commits into from
Jan 27, 2021

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Jan 20, 2021 •
edited
Loading

Closes #6543

Fixes a11y issues with ComposedModal

Changelog

New

  • ariaLabel prop for ComposedModal
  • aria-modal attribute added

Changed

  • ModalHeader now uses h2 and h3 instead of p elements

Testing / Reviewing

Ensure there are no a11y violations with Composed Modal

@tw15egan tw15egan requested a review from a team as a code owner January 20, 2021 17:22
@tw15egan tw15egan requested review from joshblack and dakahn January 20, 2021 17:22
@netlify
Copy link

netlify bot commented Jan 20, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 7ea59b3

https://deploy-preview-7609--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 20, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 7ea59b3

https://deploy-preview-7609--carbon-components-react.netlify.app

@tw15egan tw15egan requested a review from a team as a code owner January 20, 2021 18:05
@tw15egan
Copy link
Collaborator Author

@joshblack updated!

dakahn
dakahn approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Reads well in testing with NVDA on Firefox latest Windows 10

@tw15egan
Copy link
Collaborator Author

@joshblack let me know if this solution works 👍

@kodiakhq kodiakhq bot merged commit 96aa677 into carbon-design-system:master Jan 27, 2021
@tw15egan tw15egan deleted the modal-a11y-fix branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carbon Compose Modal accessibility violation
4 participants
@tw15egan @joshblack @dakahn @andreancardona