Tag filter doesn't honor type knob

[xpander53]

What package(s) are you using?

• carbon-components
• carbon-components-react

Detailed description

Describe in detail the issue you're having.

type is not being honor on a filter (tag variant)

Is this issue related to a specific component?

Yes the Tag component

What did you expect to happen? What happened instead? What would you like to
see changed?

Expect the color to change to the color I picked. For example "gray"

What browser are you working in?

Chrome

What version of the Carbon Design System are you using?

"carbon-components": "^10.3.0",
"carbon-components-react": "^7.2.0",

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Watson for Clinical Trial Matching

Steps to reproduce the issue

Change the type knob and see it works for Tab but NOT for the filter variant.
http://react.carbondesignsystem.com/?path=/story/tag--filter

Additional information

• Screenshots or code
• Notes

[emyarod]

not sure if we support different colored filter tags, but if we want to add support for that we'll need hover and focus color tokens for the close button background

[xpander53]

The story book for filter shows support for color.
http://react.carbondesignsystem.com/?path=/story/tag--filter

[emyarod]

yeah it can be unintended, in which case the storybook knob would just be removed

[elizabethsjudd]

@emyarod I know WH is in the process of creating an issue to support interactive tags in all of the colors for tags. It's common that tags can be used as a button or link (e.g. tag clouds, labels in GH, etc) so our issue will provide hover, focus, and disabled states for each individual color.

[emyarod]

cool, once we are aligned on spec I can resolve this issue. just need confirmation from design about those tokens

refs #2129

[stale]

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

[xpander53]

Bump - still valid

[stale]

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

[stale]

As there's been no activity since this issue was marked as stale, we are auto-closing it.

[xpander53]

Bump - still valid. Just because this isn't fixed in a couple of weeks doesn't make it not valid. My team needs this fixed.

[xpander53]

@emyarod Can you reopen this defect or should I open a new issue with the same issue?

[xpander53]

@emyarod Thanks!

[emyarod]

got confirmation from design that this is a desired feature, awaiting updated spec

[laurenmrice]

Yes, we definitely want this feature for Filterable Tag. Design currently has the specs for the background and text/icon color. But we currently are still working on values for the hover colors on the icon.

[janhassel]

Hey, just wanted to check on the status of this one since we are facing the same issue.

@laurenmrice What do you think about a temporary solution where we say the hover color is always the next darker (or lighter) step of the respective color. So if the tag is teal and therefore using Teal20 as the background color, the hover would be Teal 30.
And then once the design team has created the hover values for the colors, we can change them.

[stale]

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

[janhassel]

Still relevant

[xpander53]

Still relevant

[janhassel]

Are there any updates on this one?

It is crucial for us and at least a temporary solution like I described here: #3318 (comment) would already help us a lot.

[emyarod]

currently still awaiting finalized spec from design

[laurenmrice]

Sadek and Vince are currently working on a solution for this, but I am not sure what the timeline is for it. We still do need the filterable tag color options in react though.

I think we can go ahead with Jans temporary solution of stepping the hover down one grade for the light themes (ex: Gray 30) and stepping the hover up one grade for the dark themes (Ex: Gray 70) and then we can change it once we have Sadek and Vinces solution (hopefully soon).

[emyarod]

may be related #5269

[vpicone]

@emyarod that issue is only for interactive tokens, it isn't used to generate a hover color for every color token we have. The same tool could be used to generate those values though maybe.

[janhassel]

I opened a PR implementing the temporary solution described earlier in this issue: #5382

[janhassel]

@emyarod Do you think this issue can be closed now since #5382 is merged or should it remain open to track the long-term solution @laurenmrice mentioned?

[laurenmrice]

This can be closed, I can make a new issue to transfer hover colors for components when they have a solution. 👍🏻