Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to change color of filterable tag in Carbon react storybook #5484

Closed
vsnichols opened this issue Feb 28, 2020 · 4 comments
Closed

Comments

@vsnichols
Copy link

Not able to change color of filterable tag in Carbon react storybook (browser: firefox)

The color switcher knob works for the normal tag, but not for the filterable one. https://carbon-components-react.netlify.com/?path=/story/tag--filter

Actual

Screen Shot 2020-02-28 at 8 31 58 AM

Expected

Should be able to switch colors

@tw15egan
Copy link
Collaborator

Currently, the filterable tag is specifically set to tag-theme($inverse-02, $inverse-01);

@carbon-design-system/design, should filterable version have all color options available?

@emyarod
Copy link
Member

emyarod commented Feb 28, 2020

ref #3318

I have been blocked on this issue for a while now, but #5382 was opened recently and is currently undergoing revisions

@laurenmrice
Copy link
Member

Yes, the filter tag should have all color options. working on it in the #5382 pr. Eventually we will also be updating the hover colors to the calculations that Vince and Sadek come up with.

@tw15egan
Copy link
Collaborator

Going to close this in favor of #3318 then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants