Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag component's type is not working if you set filter property as true #5001

Closed
2 tasks done
georginaso opened this issue Jan 10, 2020 · 2 comments
Closed
2 tasks done

Comments

@georginaso
Copy link

georginaso commented Jan 10, 2020

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

If you use the Tag component as a filter, the "type" property (for the color) doesn't work.

If you put one of these types "red", "magenta", "purple", "blue", "cyan", "teal", "green", "gray", "cool-gray" or "warm-gray" to the Tag component, it should change the color. It is working fine if the filter property has value "false" but it's not working if it's "true".

Browser: Safari

Carbon Design System versions:
[email protected]
[email protected]

Steps to reproduce the issue

Using the storybook provided: http://react.carbondesignsystem.com/?path=/story/tag--filter

  1. Go to the Knobs tab (you can see that the type is set to red and it's not working)

Test case in CodeSandbox:
https://codesandbox.io/s/poc-carbon-ui-tag-j21bv

@emyarod
Copy link
Member

emyarod commented Jan 10, 2020

related #3318, currently awaiting design feedback

@emyarod emyarod closed this as completed Jan 10, 2020
@georginaso
Copy link
Author

related #3318, currently awaiting design feedback

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants