Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataTableSkeleton component to v10 #3032

Closed
2 tasks
dallashudgens opened this issue Jun 12, 2019 · 9 comments · Fixed by #5752
Closed
2 tasks

Update DataTableSkeleton component to v10 #3032

dallashudgens opened this issue Jun 12, 2019 · 9 comments · Fixed by #5752

Comments

@dallashudgens
Copy link

dallashudgens commented Jun 12, 2019

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

I'm using the DataTableSkeleton component as a loading pattern before the data from my DataTable renders. The difference in styles is creating a lot of jumping and repositioning.

Is this issue related to a specific component?

DataTableSkeleton component

What did you expect to happen? What happened instead? What would you like to
see changed?

I expected to see the v10 styles on the skeleton component. It still had v9 which caused the header styles and rows to be a bit different, and it didn't include the table title and description.

What browser are you working in?

Chrome

What version of the Carbon Design System are you using?

v10

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

This was discovered while working on the Developer Essentials tutorial

Steps to reproduce the issue

  1. Run the 3rd Tutorial step (completed) to see the DataTableSkeleton load in with different styles.

Additional information

@asudoh
Copy link
Contributor

asudoh commented Jun 13, 2019

CC @carbon-design-system/design just in case they have any insights wrt where we are at.

@aagonzales
Copy link
Member

aagonzales commented Jun 14, 2019

http://react.carbondesignsystem.com/?path=/story/datatableskeleton--default

Yeah looks like it wasn't updated in the code, entire skeleton table looks like its still in the V9 style. Good catch. This is what it should look like and should be using the new skeleton tokens:

image

@carbon-design-system/developers let me know if you need more specs to update.

@aagonzales
Copy link
Member

@asudoh actually it looks like none of the Skeleton states in the react story book have been updated to v10

@asudoh
Copy link
Contributor

asudoh commented Jun 14, 2019

Thanks @aagonzales for your insights - Yes, having specs will be great!

@aagonzales
Copy link
Member

xlg-1312px-16 column

@aagonzales
Copy link
Member

React data table skeleton is still doesn't match intended design list above:

As-is:
image

To-be:
image

@tw15egan
Copy link
Collaborator

@nictownsend
Copy link
Contributor

Can this be conditional via props? I don't want to have a header or buttons but now I'm forced to, which has broken the loading state UX for my tables...

@richardpilot
Copy link

We also need this to be optional. This component seems to have regressed in function, as it is missing the headers, which we were providing so shouldn't be a skeleton and also add the top header title which we don't use. We now have to hide it in css or use the old version of this component as our own which is not very future proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants