-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DataTableSkeleton component to v10 #3032
Comments
CC @carbon-design-system/design just in case they have any insights wrt where we are at. |
http://react.carbondesignsystem.com/?path=/story/datatableskeleton--default Yeah looks like it wasn't updated in the code, entire skeleton table looks like its still in the V9 style. Good catch. This is what it should look like and should be using the new skeleton tokens: @carbon-design-system/developers let me know if you need more specs to update. |
@asudoh actually it looks like none of the Skeleton states in the react story book have been updated to v10 |
Thanks @aagonzales for your insights - Yes, having specs will be great! |
Still has not been updated (http://react.carbondesignsystem.com/?path=/story/datatableskeleton--default) |
Can this be conditional via props? I don't want to have a header or buttons but now I'm forced to, which has broken the loading state UX for my tables... |
We also need this to be optional. This component seems to have regressed in function, as it is missing the headers, which we were providing so shouldn't be a skeleton and also add the top header title which we don't use. We now have to hide it in css or use the old version of this component as our own which is not very future proof. |
What package(s) are you using?
carbon-components
carbon-components-react
Detailed description
I'm using the DataTableSkeleton component as a loading pattern before the data from my DataTable renders. The difference in styles is creating a lot of jumping and repositioning.
DataTableSkeleton component
I expected to see the v10 styles on the skeleton component. It still had v9 which caused the header styles and rows to be a bit different, and it didn't include the table title and description.
Chrome
v10
This was discovered while working on the Developer Essentials tutorial
Steps to reproduce the issue
Additional information
The text was updated successfully, but these errors were encountered: