Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-table): update skeleton style for v10 #5752

Merged
merged 5 commits into from
Apr 2, 2020
Merged

fix(data-table): update skeleton style for v10 #5752

merged 5 commits into from
Apr 2, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Mar 31, 2020

Fixes #3032.

Changelog

Changed

  • Skeleton style update for v10.

Testing / Reviewing

Testing should make sure data table skeleton is not broken.

@asudoh asudoh requested review from emyarod, a team and aagonzales and removed request for a team March 31, 2020 08:19
@ghost ghost requested review from joshblack and removed request for a team March 31, 2020 08:19
@netlify
Copy link

netlify bot commented Mar 31, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 71c924c

https://deploy-preview-5752--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Mar 31, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 71c924c

https://deploy-preview-5752--carbon-components-react.netlify.com

@asudoh asudoh requested a review from a team as a code owner March 31, 2020 08:37
aagonzales
aagonzales requested changes Mar 31, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually remove the icons from the toolbar. I know they're in the spec images but now I think its better if they weren't shown because when the table loads it might not have those exact icons.

image

@asudoh
Copy link
Contributor Author

asudoh commented Apr 1, 2020

now I think its better if they weren't shown because when the table loads it might not have those exact icons.

Got it @aagonzales - Updated.

tw15egan
tw15egan approved these changes Apr 1, 2020
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 👍 ✅

@asudoh asudoh requested a review from aagonzales April 1, 2020 21:20
aagonzales
aagonzales approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@asudoh asudoh merged commit 10c5f7f into carbon-design-system:master Apr 2, 2020
@asudoh asudoh deleted the data-table-skeleton branch April 2, 2020 22:36
@joshblack joshblack mentioned this pull request Apr 8, 2020
Closed
@robherley robherley mentioned this pull request Apr 30, 2020
Closed
@tw15egan tw15egan mentioned this pull request Jun 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@aagonzales aagonzales aagonzales approved these changes

@joshblack joshblack joshblack approved these changes

@emyarod emyarod Awaiting requested review from emyarod

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update DataTableSkeleton component to v10
4 participants
@asudoh @joshblack @aagonzales @tw15egan