Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataTableSkeleton] Component adds extra, unwanted skeleton behaviour #6054

Closed
2 tasks done
richardpilot opened this issue May 8, 2020 · 1 comment
Closed
2 tasks done

Comments

@richardpilot
Copy link

  • carbon-components
  • carbon-components-react

Detailed description

Issue #3032 updated the DataTableSkeleton component but that now breaks existing users of the components who weren't using all DataTable features. In our specific use case, we don't use DataTableContainer and thus don't have the title or description. When a user opens our page, it now jumps UI element around after loading.

Please either revert this to the previous behaviour or add optional props to inform the skeleton which parts should be shown.

A minor point, but this also now hides the table headers despite being passed to them as props.

Expected

image

As-is

image

@asudoh
Copy link
Contributor

asudoh commented May 8, 2020

Hi 👋 thank you for reporting. Same as #5993, let's discuss further there.

@asudoh asudoh closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants