Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename slug classes to ai-label #17714

Closed
3 tasks
Tracked by #17921
tay1orjones opened this issue Oct 10, 2024 · 2 comments · Fixed by #17972
Closed
3 tasks
Tracked by #17921

Rename slug classes to ai-label #17714

tay1orjones opened this issue Oct 10, 2024 · 2 comments · Fixed by #17972
Assignees
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Oct 10, 2024

When Slug was renamed to AILabel(#16803), the props and classnames were not included in the rename. This issue is to fix that.

This rename needs to be backwards compatible. The approach we could take could be:

  • Add new duplicate classname selectors to the ailabel.scss styles
    - .#{$prefix}--slug .#{$prefix}--slug__button {
    
    + .#{$prefix}--slug .#{$prefix}--slug__button,
    + .#{$prefix}--ai-label .#{$prefix}--ai-label__button { 
  • Update classnames within AILabel components to use the new #{$prefix}--ai-label names
  • Create a new sub-issue/tasklist item on v12 #15803 for removing these classes as part of v12

Note

On casing: for situations like react where we have to use PascalCase we decided on AILabel

For non-pascalcase situations like classnames I think the codebase convention would be "sausage-case" (or whatever you like to call it 🙃 ): ai-label

@ariellalgilmore
Copy link
Member

we decided on using decorator as a general term

@alisonjoseph
Copy link
Member

alisonjoseph commented Oct 30, 2024

Related issue: #17303

We also want to update the styles so that the AI styles only apply when the child of decorator is the AILabel component.

@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants