We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slug
ai-label
When Slug was renamed to AILabel(#16803), the props and classnames were not included in the rename. This issue is to fix that.
This rename needs to be backwards compatible. The approach we could take could be:
ailabel.scss
- .#{$prefix}--slug .#{$prefix}--slug__button { + .#{$prefix}--slug .#{$prefix}--slug__button, + .#{$prefix}--ai-label .#{$prefix}--ai-label__button {
#{$prefix}--ai-label
Note
On casing: for situations like react where we have to use PascalCase we decided on AILabel
AILabel
For non-pascalcase situations like classnames I think the codebase convention would be "sausage-case" (or whatever you like to call it 🙃 ): ai-label
The text was updated successfully, but these errors were encountered:
we decided on using decorator as a general term
decorator
Sorry, something went wrong.
Related issue: #17303
We also want to update the styles so that the AI styles only apply when the child of decorator is the AILabel component.
ariellalgilmore
Successfully merging a pull request may close this issue.
When Slug was renamed to AILabel(#16803), the props and classnames were not included in the rename. This issue is to fix that.
This rename needs to be backwards compatible. The approach we could take could be:
ailabel.scss
styles#{$prefix}--ai-label
namesNote
On casing: for situations like react where we have to use PascalCase we decided on
AILabel
For non-pascalcase situations like classnames I think the codebase convention would be "sausage-case" (or whatever you like to call it 🙃 ):
ai-label
The text was updated successfully, but these errors were encountered: