-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tearsheet): Slug to aiLabel #6169
feat(Tearsheet): Slug to aiLabel #6169
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few typos. “Scenario” and “accountability” were spelled slightly wrong but I think I caught them all. :)
packages/ibm-products/src/components/Tearsheet/Tearsheet.stories.jsx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/Tearsheet/Tearsheet.stories.jsx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/Tearsheet/TearsheetShell.tsx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/Tearsheet/TearsheetShell.tsx
Outdated
Show resolved
Hide resolved
Spelling issues Co-authored-by: elysia <[email protected]>
Spelling issues Co-authored-by: elysia <[email protected]>
…es.jsx Spelling issues Co-authored-by: elysia <[email protected]>
…es.jsx text case update Co-authored-by: elysia <[email protected]>
Spelling issues Co-authored-by: elysia <[email protected]>
Spelling issues Co-authored-by: elysia <[email protected]>
Thanks @elycheea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6169 +/- ##
==========================================
- Coverage 78.68% 78.67% -0.02%
==========================================
Files 395 395
Lines 12794 12795 +1
Branches 4214 4215 +1
==========================================
- Hits 10067 10066 -1
- Misses 2727 2729 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5c0f2ad
Closes #6096
Rename the prop
slug
toaiLabel
.What did you change?
aiLabel
slug
propHow did you test and verify your work?
Storybook