Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-label): update classes from slug to ai-label #17972

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Nov 5, 2024

Closes #17714

Update AILabel to use classes ai-label instead of slug

Changelog

Changed

  • updated AILabel component classes and updated old doc links
  • updated all components using AILabel to have duplicate scss selectors for both ai-label and slug classes
    • the slug classes will eventually be removed in v12
  • updated date-picker fluid, so that styles would match regular date-picker to have the ai-gradient be applied on the input level

Testing / Reviewing

Confirm components using AILabel still show/hide ai gradients when using AILabel inside the component

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 2bf10b2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/672c42338b49870008f01562
😎 Deploy Preview https://deploy-preview-17972--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e7bf236
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/672a586f039a4200084a8ff7
😎 Deploy Preview https://deploy-preview-17972--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit e7bf236
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672a586fcf20ff0008d01953
😎 Deploy Preview https://deploy-preview-17972--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 85af631
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/672a58bf8990070008fe1707
😎 Deploy Preview https://deploy-preview-17972--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit ccbf58b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672a5a7230c4e80008772421
😎 Deploy Preview https://deploy-preview-17972--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2bf10b2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/672c4233fe18ba00085473c4
😎 Deploy Preview https://deploy-preview-17972--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit c903665
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672a5b3661cfec00085ef7da
😎 Deploy Preview https://deploy-preview-17972--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 2bf10b2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672c4233ffe8cc00082a8758
😎 Deploy Preview https://deploy-preview-17972--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (cdc8db7) to head (2bf10b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17972      +/-   ##
==========================================
- Coverage   81.82%   81.81%   -0.01%     
==========================================
  Files         404      404              
  Lines       14067    14067              
  Branches     4360     4360              
==========================================
- Hits        11510    11509       -1     
- Misses       2395     2396       +1     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review November 5, 2024 18:25
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner November 5, 2024 18:25
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ariellalgilmore ariellalgilmore added this pull request to the merge queue Nov 7, 2024
Merged via the queue into carbon-design-system:main with commit 0cfda56 Nov 7, 2024
39 of 40 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/ai-label-rename-classes branch November 7, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename slug classes to ai-label
3 participants