Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cwc): generate cwc internal vendor package #9899

Merged

Conversation

annawen1
Copy link
Member

Related Ticket(s)

[carbon-web-components]: updating build scripts to use internal vendor packages #9763

Description

This PR adds the the gulp tasks to build cwc to the internal vendor folder and changes the paths in web-components to reference the internal files instead.

Changelog

New

  • add to the gulp tasks in web-components to build out the carbon-web-components internal vendor package

Changed

  • change paths to reference the internal carbon-web-components vendor files instead

@annawen1 annawen1 requested a review from a team as a code owner January 11, 2023 23:17
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 11, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 11, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 11, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2023

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just looks like something is going on with the ci/e2e tests.

@ibmdotcom-bot
Copy link
Contributor

@kennylam kennylam added Ready to merge Label for the pull requests that are ready to merge and removed 🛠️ fix needed labels Jan 23, 2023
@kodiakhq kodiakhq bot merged commit 987c620 into carbon-design-system:main Jan 23, 2023
annawen1 added a commit that referenced this pull request Jan 23, 2023
kodiakhq bot pushed a commit that referenced this pull request Jan 24, 2023
Reverts #9899

Still some issues with the `ButtonGroup` and other components using `ButtonGroup` in the React Wrapper stories
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
…m#9899)

### Related Ticket(s)

[carbon-web-components]: updating build scripts to use internal vendor packages carbon-design-system#9763

### Description

This PR adds the the gulp tasks to build cwc to the internal vendor folder and changes the paths in web-components to reference the internal files instead.

### Changelog

**New**

- add to the gulp tasks in `web-components` to build out the `carbon-web-components` internal vendor package

**Changed**

- change paths to reference the internal `carbon-web-components` vendor files instead

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
…ign-system#9937)

Reverts carbon-design-system#9899

Still some issues with the `ButtonGroup` and other components using `ButtonGroup` in the React Wrapper stories
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
…m#9899)

### Related Ticket(s)

[carbon-web-components]: updating build scripts to use internal vendor packages carbon-design-system#9763

### Description

This PR adds the the gulp tasks to build cwc to the internal vendor folder and changes the paths in web-components to reference the internal files instead.

### Changelog

**New**

- add to the gulp tasks in `web-components` to build out the `carbon-web-components` internal vendor package

**Changed**

- change paths to reference the internal `carbon-web-components` vendor files instead

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
…ign-system#9937)

Reverts carbon-design-system#9899

Still some issues with the `ButtonGroup` and other components using `ButtonGroup` in the React Wrapper stories
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
…ign-system#9937)

Reverts carbon-design-system/carbon-for-ibm-dotcom#9899

Still some issues with the `ButtonGroup` and other components using `ButtonGroup` in the React Wrapper stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants