-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cwc): generate cwc internal vendor package #9899
chore(cwc): generate cwc internal vendor package #9899
Conversation
Deploy preview created for package Built with commit: 7a599df50caff0b8267db373a3c9f5c44dd31482 |
Deploy preview created for package Built with commit: 7a599df50caff0b8267db373a3c9f5c44dd31482 |
Deploy preview created for package Built with commit: 7a599df50caff0b8267db373a3c9f5c44dd31482 |
Deploy preview created for package Built with commit: 7a599df50caff0b8267db373a3c9f5c44dd31482 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just looks like something is going on with the ci/e2e tests.
Deploy preview created for package Built with commit: 7a599df50caff0b8267db373a3c9f5c44dd31482 |
Reverts #9899 Still some issues with the `ButtonGroup` and other components using `ButtonGroup` in the React Wrapper stories
…m#9899) ### Related Ticket(s) [carbon-web-components]: updating build scripts to use internal vendor packages carbon-design-system#9763 ### Description This PR adds the the gulp tasks to build cwc to the internal vendor folder and changes the paths in web-components to reference the internal files instead. ### Changelog **New** - add to the gulp tasks in `web-components` to build out the `carbon-web-components` internal vendor package **Changed** - change paths to reference the internal `carbon-web-components` vendor files instead <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…ign-system#9937) Reverts carbon-design-system#9899 Still some issues with the `ButtonGroup` and other components using `ButtonGroup` in the React Wrapper stories
…m#9899) ### Related Ticket(s) [carbon-web-components]: updating build scripts to use internal vendor packages carbon-design-system#9763 ### Description This PR adds the the gulp tasks to build cwc to the internal vendor folder and changes the paths in web-components to reference the internal files instead. ### Changelog **New** - add to the gulp tasks in `web-components` to build out the `carbon-web-components` internal vendor package **Changed** - change paths to reference the internal `carbon-web-components` vendor files instead <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…ign-system#9937) Reverts carbon-design-system#9899 Still some issues with the `ButtonGroup` and other components using `ButtonGroup` in the React Wrapper stories
…ign-system#9937) Reverts carbon-design-system/carbon-for-ibm-dotcom#9899 Still some issues with the `ButtonGroup` and other components using `ButtonGroup` in the React Wrapper stories
Related Ticket(s)
[carbon-web-components]: updating build scripts to use internal vendor packages #9763
Description
This PR adds the the gulp tasks to build cwc to the internal vendor folder and changes the paths in web-components to reference the internal files instead.
Changelog
New
web-components
to build out thecarbon-web-components
internal vendor packageChanged
carbon-web-components
vendor files instead