Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(CodeSnippet): replaced tokens #9937

Merged
merged 2 commits into from
Oct 26, 2021
Merged

style(CodeSnippet): replaced tokens #9937

merged 2 commits into from
Oct 26, 2021

Conversation

sstrubberg
Copy link
Member

REF #9888

Updated tokens to v11.

@sstrubberg sstrubberg requested a review from a team as a code owner October 25, 2021 15:48
joshblack
joshblack suggested changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update @use '../../compat/theme' to @use '../../theme' 👍

Unfortunately, our internal usage of the compat theme is causing some issues downstream with beta testers so we want to make sure we're using the theme import instead 👀

@netlify
Copy link

netlify bot commented Oct 25, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 0a9b28c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6176d2b6f713bd0007407fff

😎 Browse the preview: https://deploy-preview-9937--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0a9b28c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6176d2b6b6ea050008322d8f

😎 Browse the preview: https://deploy-preview-9937--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 0a9b28c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6176d2b63a194e00083c98ef

😎 Browse the preview: https://deploy-preview-9937--carbon-elements.netlify.app

@sstrubberg sstrubberg requested a review from joshblack October 25, 2021 17:46
@sstrubberg sstrubberg merged commit 532a5c9 into carbon-design-system:main Oct 26, 2021
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@annawen1
Revert "chore(cwc): generate cwc internal vendor package" (carbon-des…
22414a1 
…ign-system#9937)

Reverts carbon-design-system/carbon-for-ibm-dotcom#9899

Still some issues with the `ButtonGroup` and other components using `ButtonGroup` in the React Wrapper stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sstrubberg @joshblack @jnm2377