Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore(cwc): generate cwc internal vendor package" #9937

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Revert "chore(cwc): generate cwc internal vendor package" #9937

merged 2 commits into from
Jan 24, 2023

Conversation

annawen1
Copy link
Member

Reverts #9899

Still some issues with the ButtonGroup and other components using ButtonGroup in the React Wrapper stories

@annawen1 annawen1 requested a review from a team as a code owner January 23, 2023 19:37
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 23, 2023 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9937/index.html

Built with commit: 7f1bdb504c676fb3d124a02d33391535b6845b27

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 23, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9937/index.html

Built with commit: 7f1bdb504c676fb3d124a02d33391535b6845b27

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 23, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9937/index.html

Built with commit: 7f1bdb504c676fb3d124a02d33391535b6845b27

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 23, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9937/index.html

Built with commit: 7f1bdb504c676fb3d124a02d33391535b6845b27

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Jan 24, 2023
@kodiakhq kodiakhq bot merged commit b6019fc into main Jan 24, 2023
@kodiakhq kodiakhq bot deleted the revert-9899-feat/cwc-internal-vendor-build branch January 24, 2023 07:27
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@annawen1
Revert "chore(cwc): generate cwc internal vendor package" (carbon-des…
88fcdab 
…ign-system#9937)

Reverts carbon-design-system#9899

Still some issues with the `ButtonGroup` and other components using `ButtonGroup` in the React Wrapper stories
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@annawen1
Revert "chore(cwc): generate cwc internal vendor package" (carbon-des…
067beed 
…ign-system#9937)

Reverts carbon-design-system#9899

Still some issues with the `ButtonGroup` and other components using `ButtonGroup` in the React Wrapper stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annawen1 @ibmdotcom-bot @kennylam