fix(masthead-search): react searchNoRedirect prop doesn't work on enter #8541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er (carbon-design-system#8516) ### Related Ticket(s) carbon-design-system#8334 ### Description people using the `searchNoRedirect` prop and press enter within the search box are still being redirected. The `onKeyDown` was removed in this [PR](carbon-design-system#7365), but it is actually necessary when the `searchNoRedirect` is used ### Changelog **New** - added back the `onKeyDown` function <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> (cherry picked from commit a176c21)
|
Deploy preview created for package Built with commit: 8111c5d8c2886dd14e848434c9179d391c8a8f1b |
|
Deploy preview created for package Built with commit: fcabb0b76129e9f0e42026fa323a64e5dd1e8319 |
|
Deploy preview created for package Built with commit: 8111c5d8c2886dd14e848434c9179d391c8a8f1b |
kennylam
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
#8334
Description
people using the
searchNoRedirectprop and press enter within the search box are still being redirected. TheonKeyDownwas removed in this PR, but it is actually necessary when thesearchNoRedirectis usedChangelog
New
onKeyDownfunction(cherry picked from commit a176c21)