Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(masthead-search): react searchNoRedirect prop doesn't work on enter #8516

Merged
merged 5 commits into from
Mar 16, 2022
Merged

fix(masthead-search): react searchNoRedirect prop doesn't work on enter #8516

merged 5 commits into from
Mar 16, 2022

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

#8334

Description

people using the searchNoRedirect prop and press enter within the search box are still being redirected. The onKeyDown was removed in this PR, but it is actually necessary when the searchNoRedirect is used

Changelog

New

  • added back the onKeyDown function

@ariellalgilmore ariellalgilmore added the package: react Work necessary for the Carbon for IBM.com react components package label Mar 16, 2022
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner March 16, 2022 18:32
@annawen1 annawen1 requested a review from emyarod March 16, 2022 19:09
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 16, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8516/index.html

Built with commit: 52e974eb92e44118b401152cd2dcf3871773b96f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 16, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8516/index.html

Built with commit: 52e974eb92e44118b401152cd2dcf3871773b96f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 16, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8516/index.html

Built with commit: 52e974eb92e44118b401152cd2dcf3871773b96f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 16, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8516/index.html

Built with commit: 52e974eb92e44118b401152cd2dcf3871773b96f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 16, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8516/index.html

Built with commit: 52e974eb92e44118b401152cd2dcf3871773b96f

emyarod
emyarod approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! not sure if we want to include a break and default case in the switch statement for best practices, but right now the switch is fine as is

@emyarod emyarod mentioned this pull request Mar 16, 2022
Closed
IgnacioBecerra
IgnacioBecerra approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ariellalgilmore!

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Mar 16, 2022
@kodiakhq kodiakhq bot merged commit a176c21 into carbon-design-system:main Mar 16, 2022
@ariellalgilmore ariellalgilmore deleted the fix/masthead-search-react-enter branch March 16, 2022 21:19
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 17, 2022
@ariellalgilmore @kennylam
fix(masthead-search): react searchNoRedirect prop doesn't work on ent…
e7c73ae 
…er (carbon-design-system#8516)

### Related Ticket(s)

carbon-design-system#8334

### Description

people using the `searchNoRedirect` prop and press enter within the search box are still being redirected. The `onKeyDown` was removed in this [PR](carbon-design-system#7365), but it is actually necessary when the `searchNoRedirect` is used

### Changelog

**New**

- added back the `onKeyDown` function

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->

(cherry picked from commit a176c21)
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 17, 2022
@ariellalgilmore @kennylam
fix(masthead-search): react searchNoRedirect prop doesn't work on ent…
d1002db 
…er (carbon-design-system#8516)

### Related Ticket(s)

carbon-design-system#8334

### Description

people using the `searchNoRedirect` prop and press enter within the search box are still being redirected. The `onKeyDown` was removed in this [PR](carbon-design-system#7365), but it is actually necessary when the `searchNoRedirect` is used

### Changelog

**New**

- added back the `onKeyDown` function

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->

(cherry picked from commit a176c21)
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 17, 2022
@ariellalgilmore @kennylam
fix(masthead-search): react searchNoRedirect prop doesn't work on ent…
fcabb0b 
…er (carbon-design-system#8516)

### Related Ticket(s)

carbon-design-system#8334

### Description

people using the `searchNoRedirect` prop and press enter within the search box are still being redirected. The `onKeyDown` was removed in this [PR](carbon-design-system#7365), but it is actually necessary when the `searchNoRedirect` is used

### Changelog

**New**

- added back the `onKeyDown` function

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->

(cherry picked from commit a176c21)
kennylam added a commit that referenced this pull request Mar 17, 2022
@kennylam @ariellalgilmore
fix(masthead-search): react searchNoRedirect prop doesn't work on ent…
d1d1c95 
…er (#8516) (#8541)

### Related Ticket(s)

#8334

### Description

people using the `searchNoRedirect` prop and press enter within the search box are still being redirected. The `onKeyDown` was removed in this [PR](#7365), but it is actually necessary when the `searchNoRedirect` is used

### Changelog

**New**

- added back the `onKeyDown` function

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->

(cherry picked from commit a176c21)

Co-authored-by: Ariella Gilmore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@emyarod emyarod emyarod approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ariellalgilmore @ibmdotcom-bot @emyarod @IgnacioBecerra