[Masthead]: searchNoRedirect prop no longer working in 1.30.0 #8334
Assignees
Labels
bug
Something isn't working
dev
Needs some dev work
package: react
Work necessary for the Carbon for IBM.com react components package
priority: high
severity 2
Affects major functionality, has a workaround
Sprint Must Have
Comments
ljcarot
added
package: react
kodiakhq bot
pushed a commit
that referenced
this issue
Mar 16, 2022
…er (#8516) ### Related Ticket(s) #8334 ### Description people using the `searchNoRedirect` prop and press enter within the search box are still being redirected. The `onKeyDown` was removed in this [PR](#7365), but it is actually necessary when the `searchNoRedirect` is used ### Changelog **New** - added back the `onKeyDown` function <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
|
Hi, any idea when this will be released? |
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this issue
Mar 17, 2022
…er (carbon-design-system#8516) ### Related Ticket(s) carbon-design-system#8334 ### Description people using the `searchNoRedirect` prop and press enter within the search box are still being redirected. The `onKeyDown` was removed in this [PR](carbon-design-system#7365), but it is actually necessary when the `searchNoRedirect` is used ### Changelog **New** - added back the `onKeyDown` function <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> (cherry picked from commit a176c21)
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this issue
Mar 17, 2022
…er (carbon-design-system#8516) ### Related Ticket(s) carbon-design-system#8334 ### Description people using the `searchNoRedirect` prop and press enter within the search box are still being redirected. The `onKeyDown` was removed in this [PR](carbon-design-system#7365), but it is actually necessary when the `searchNoRedirect` is used ### Changelog **New** - added back the `onKeyDown` function <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> (cherry picked from commit a176c21)
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this issue
Mar 17, 2022
…er (carbon-design-system#8516) ### Related Ticket(s) carbon-design-system#8334 ### Description people using the `searchNoRedirect` prop and press enter within the search box are still being redirected. The `onKeyDown` was removed in this [PR](carbon-design-system#7365), but it is actually necessary when the `searchNoRedirect` is used ### Changelog **New** - added back the `onKeyDown` function <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> (cherry picked from commit a176c21)
kennylam
added a commit
that referenced
this issue
Mar 17, 2022
…er (#8516) (#8541) ### Related Ticket(s) #8334 ### Description people using the `searchNoRedirect` prop and press enter within the search box are still being redirected. The `onKeyDown` was removed in this [PR](#7365), but it is actually necessary when the `searchNoRedirect` is used ### Changelog **New** - added back the `onKeyDown` function <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> (cherry picked from commit a176c21) Co-authored-by: Ariella Gilmore <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
<MastheadsearchNoRedirect>It works correctly in 1.24.0 but no longer works in 1.30.0 upon pressing the Enter key while inside the search box. It does not block the default redirect action as it should and performs the redirect anyway. Using identical code. This breaks my application.
Component(s) impacted
Masthead
Browser
Chrome, Safari, Firefox, Microsoft Edge
Carbon for IBM.com version
1.30.0
Severity
Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.
Application/website
Redbooks
Package
@carbon/ibmdotcom-react
CodeSandbox example
https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/react/examples/codesandbox/components/Masthead?file=/src/App.js
Steps to reproduce the issue (if applicable)
Use component
<Masthead searchNoRedirect />Type a keyword into search box. Press ENTER. This should result in no action as the searchNoRedirect prop should be blocking the default redirect. Instead, it redirects.
Release date (if applicable)
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: