Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(card-in-card): ensure that the card image is clickable #8361

Merged
merged 6 commits into from
Feb 26, 2022
Merged

fix(card-in-card): ensure that the card image is clickable #8361

merged 6 commits into from
Feb 26, 2022

Conversation

proeung
Copy link
Contributor

@proeung proeung commented Feb 23, 2022

Related Ticket(s)

#8300

Description

Changelog

New

  • Add a new variable declaration for checking for <dds-card-in-card-image> that's wrapped under <dds-video-cta-container>.

@proeung proeung added package: web components Work necessary for the IBM.com Library web components package 👀 eyes needed labels Feb 23, 2022
@proeung proeung requested a review from a team as a code owner February 23, 2022 18:13
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 23, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8361/index.html

Built with commit: 0024f6718ad58c0a96a7c2b6b25f0e0c9a0a9407

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 23, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8361/index.html

Built with commit: 0024f6718ad58c0a96a7c2b6b25f0e0c9a0a9407

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 23, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8361/index.html

Built with commit: 0024f6718ad58c0a96a7c2b6b25f0e0c9a0a9407

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 23, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8361/index.html

Built with commit: 0024f6718ad58c0a96a7c2b6b25f0e0c9a0a9407

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 23, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8361/index.html

Built with commit: 0024f6718ad58c0a96a7c2b6b25f0e0c9a0a9407

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 24, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8361/index.html

Built with commit: 6136ea79728feca5bc163dc7e6f214b1618f0d5b

@proeung
Copy link
Contributor Author

proeung commented Feb 24, 2022

@IgnacioBecerra Thanks for the review! I added a commit that should address your feedback. Let me know if you need anything else.

RichKummer
RichKummer approved these changes Feb 24, 2022
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the change in Chrome/Firefox and it's working. Thanks @proeung !

@RichKummer RichKummer mentioned this pull request Feb 24, 2022
Closed
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8361/index.html

Built with commit: 6136ea79728feca5bc163dc7e6f214b1618f0d5b

@IgnacioBecerra IgnacioBecerra mentioned this pull request Feb 25, 2022
Closed
IgnacioBecerra
IgnacioBecerra approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @proeung!

@IgnacioBecerra IgnacioBecerra added Ready to merge Label for the pull requests that are ready to merge and removed 👀 eyes needed labels Feb 25, 2022
@kodiakhq kodiakhq bot merged commit 487e8e9 into carbon-design-system:main Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@RichKummer RichKummer RichKummer approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@proeung @ibmdotcom-bot @RichKummer @IgnacioBecerra