Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Card in card]: Can't click on video - DPO Consulting #8300

Closed
2 tasks done
RichKummer opened this issue Feb 16, 2022 · 0 comments
Closed
2 tasks done

[Card in card]: Can't click on video - DPO Consulting #8300

RichKummer opened this issue Feb 16, 2022 · 0 comments
Assignees
Labels
bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package

Comments

@RichKummer
Copy link

RichKummer commented Feb 16, 2022

Engineering info:


Description

In Firefox using the React wrapper Storybook, I should be able to click on the video background of Card in card when a video is present to launch the video. When I try to click the video background, the overlay with the full video will not launch - nothing happens. I can still launch the video by clicking the smaller card, but the background should also trigger it.

Screen Shot 2022-02-16 at 11 41 38 AM

Component(s) impacted

Card in card

Browser

Firefox

Carbon for IBM.com version

v1.31.0-rc.1

Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Application/website

C4IBM.com

Package

@carbon/ibmdotcom-web-components

CodeSandbox example

https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/web-components/examples/codesandbox/components-react/card-in-card

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

@RichKummer RichKummer added bug Something isn't working package: web components Work necessary for the IBM.com Library web components package labels Feb 16, 2022
@kennylam kennylam added owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants and removed follow-up: innovation team labels Feb 21, 2022
@kennylam kennylam changed the title [Card in card]: Can't click on video [Card in card]: Can't click on video - DPO Consulting Feb 21, 2022
kodiakhq bot pushed a commit that referenced this issue Feb 26, 2022
### Related Ticket(s)

#8300

### Description

- This PR addresses the issue where the card image within the `<dds-card-in-card>` is not clickable.
- See the issue for more detail - #8300

### Changelog

**New**

- Add a new variable declaration for checking for `<dds-card-in-card-image>` that's wrapped under `<dds-video-cta-container>`.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@proeung proeung closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package
Projects
None yet
Development

No branches or pull requests

8 participants