chore(ui): Upgrade UI dependencies #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
force-pushed
the
upgrade_ui_dependencies
branch
from
f8b2d26
to
4598083
Compare
deadlycoconuts
force-pushed
the
upgrade_ui_dependencies
branch
from
9d7cafe
to
4467270
Compare
deadlycoconuts
commented
Jul 10, 2024
deadlycoconuts
commented
Jul 10, 2024
deadlycoconuts
commented
Jul 15, 2024
deadlycoconuts
commented
Jul 15, 2024
deadlycoconuts
commented
Jul 15, 2024
deadlycoconuts
commented
Jul 15, 2024
deadlycoconuts
commented
Jul 15, 2024
deadlycoconuts
commented
Jul 15, 2024
leonlnj
approved these changes
Jul 17, 2024
|
Yeap, I just added them as comments in the package.json file here https://github.com/caraml-dev/xp/pull/79/files#diff-193b27d62e4fbda3d563009fed5ec6761a05f73558d94b39fab63ae948c679eaR6. Thanks for the review; merging this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Similar to what had been done in MLP caraml-dev/mlp#100, Merlin caraml-dev/merlin#591 and in Turing caraml-dev/turing#384, this PR updates certain UI dependencies in XP, most notably:
package.jsonfile to pin the engine to >=20.13.1)EuiAccordion-related components; this is likely due a massive rework of the component in this PR [EuiAccordion] Split up rendering into sub-components & other cleanups elastic/eui#7161 but I've no idea why this change didn't affect the accordions in MerlinOther minor changes have also been made to the GitHub CICD files.
Main Changes
GitHub Actions Updates
actions/upload-artifact- from v2 to v4 since the former has already been deprecated since the 30th of June this yearactions/download-artifact- from v2 to v4 since the former has already been deprecated since the 30th of June this year (the versions of this action andupload-artifactneed to be compatible to work)actions/checkout- from v3 to v4 since it's similarly done in the MLP repoactions/setup-go- from v4 to v5 since it's similarly done in the MLP repo (also provides caching)actions/setup-python- from v2 to v5 to keep it updated to the latest version (also provides caching)docker/login-action- from v1 to v3 just to keep it updated to the latest version