chore: Revamp Batch Prediction Jobs UI #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
==========================================
- Coverage 60.50% 60.48% -0.02%
==========================================
Files 274 274
Lines 22066 22068 +2
==========================================
- Hits 13351 13348 -3
- Misses 7859 7863 +4
- Partials 856 857 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ariefrahmansyah
changed the title
added 2 commits
June 12, 2024 10:02
leonlnj
reviewed
Jun 13, 2024
leonlnj
reviewed
Jun 13, 2024
leonlnj
reviewed
Jun 13, 2024
leonlnj
reviewed
Jun 13, 2024
leonlnj
reviewed
Jun 13, 2024
leonlnj
reviewed
Jun 13, 2024
leonlnj
reviewed
Jun 13, 2024
leonlnj
reviewed
Jun 13, 2024
ui/src/pages/version/components/forms/components/docker_config/DockerDeploymentPanel.scss
Outdated
Show resolved
Hide resolved
leonlnj
approved these changes
Jun 13, 2024
This was referenced Jul 5, 2024
6 tasks
deadlycoconuts
added a commit
that referenced
this pull request
Jul 23, 2024
# Description Similar to caraml-dev/turing#387, this PR to fixes broken validation schemas caused by the upgrade of the `yup` package in PR #591 - these changes can largely be grouped into the following: - The `Schema.when` function has been [updated](https://github.com/jquense/yup?tab=readme-ov-file#schemawhenkeys-string--string-builder-object--values-any-schema--schema-schema), such that when the builder object (one with the fields `is`, `then`, and sometimes `otherwise` defined) is passed as an argument, the `then` field accepts ONLY functions of the following signature `(schema: Schema) => Schema` instead of `Schema` previously. Existing schemas that do not follow this convention have been updated and turned into arrow functions. Example: ```javascript // before some_field: yup.string().when("some_other_field", { is: "nop", then: yup.string().required("this is needed") }), // after some_field: yup.string().when("some_other_field", { is: "nop", then: (_) => yup.string().required("this is needed") }), ``` - When using the same `Schema.when` function but passing a function directly as an argument instead of the builder object, the signature of the expected function has also been updated from `(value, schema)=> Schema): Schema` to `(values: any[], schema) => Schema): Schema`. Existing schemas that do not follow this convention now have been updated to reflect the new expected array: Example: ```javascript // before some_field: yup.string().when("some_other_field", (some_other_field, schema) => some_other_field ? yup.string().required("this is needed") : schema ), // after some_field: yup.string().when("some_other_field", ([some_other_field], schema) => some_other_field ? yup.string().required("this is needed") : schema ), ``` ## Unrelated Update This PR also bumps up the version of the `caraml-dev/ui-lib` library to the latest version. # Modifications - UI bug fixes - Update to `caraml-dev/ui-lib` library # Tests <!-- Besides the existing / updated automated tests, what specific scenarios should be tested? Consider the backward compatibility of the changes, whether corner cases are covered, etc. Please describe the tests and check the ones that have been completed. Eg: - [x] Deploying new and existing standard models - [ ] Deploying PyFunc models --> # Checklist - [x] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [x] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes ```release-note NONE ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the UI/UX for the batch prediction job. It also upgrades the UI dependencies such as node version, react version, elasticsearch UI, and @caraml-ui/lib.
This PR also do some clean up and refactoring such as:
Modifications
a. Make model version columns clickable and link to the Version page
b. Add Status filter
a. Simplify the UI and make it similar and consistent to Version Details page
b. Logs is displayed as part of tab navigation
c. On Source Config, user can search the feature name
Tests
Checklist
Release Notes